Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] [DO NOT MERGE] Entities support prototype #11958

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[DRAFT] [DO NOT MERGE] Entities support prototype #11958

wants to merge 1 commit into from
+8,272 −67

Conversation

dmitryax
Copy link
Member

Recreated #11282

@dmitryax dmitryax force-pushed the entities-support-prototype branch from 1019e8c to 8020ee1 Compare December 19, 2024 00:02
@dmitryax dmitryax marked this pull request as draft December 19, 2024 00:02
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 19, 2024
@dmitryax dmitryax force-pushed the entities-support-prototype branch 7 times, most recently from 9a84f47 to 706c515 Compare December 19, 2024 03:49
@dmitryax dmitryax force-pushed the entities-support-prototype branch from 706c515 to e76b780 Compare December 19, 2024 04:30
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 41.54930% with 913 lines in your changes missing coverage. Please review.

Project coverage is 88.54%. Comparing base (1ddd969) to head (e76b780).

Files with missing lines Patch % Lines
service/internal/builders/connector.go 0.00% 126 Missing ⚠️
connector/xconnector/connector.go 0.00% 84 Missing ⚠️
...xporter/exporterhelper/xexporterhelper/entities.go 0.00% 81 Missing ⚠️
pdata/pentity/json.go 0.00% 70 Missing ⚠️
internal/fanoutconsumer/entities.go 0.00% 41 Missing ⚠️
pdata/pentity/pentityotlp/response.go 0.00% 41 Missing ⚠️
pdata/pentity/pentityotlp/request.go 0.00% 30 Missing ⚠️
service/internal/graph/connector.go 0.00% 29 Missing ⚠️
...porter/debugexporter/internal/otlptext/entities.go 6.89% 27 Missing ⚠️
pdata/pentity/entities.go 0.00% 25 Missing ⚠️
... and 34 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11958      +/-   ##
==========================================
- Coverage   91.62%   88.54%   -3.08%     
==========================================
  Files         447      477      +30     
  Lines       23731    25274    +1543     
==========================================
+ Hits        21743    22379     +636     
- Misses       1613     2503     +890     
- Partials      375      392      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmitryax